Fix accounting of pidfiles per process (when using multiple processes) #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase & squash? |
- Minor corrections suggested by Rubocop
Corrected the following infractions:
- [Style/PercentLiteralDelimiters](http://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/PercentLiteralDelimiters)
- [Lint/UnusedBlockArgument](http://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/UnusedBlockArgument)
- [Style/Next](http://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/Next)
- [Style/IfUnlessModifier](http://www.rubydoc.info/gems/rubocop/0.9.1/Rubocop/Cop/Style/IfUnlessModifier)
- [Lint/UnderscorePrefixedVariableName](http://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/UnderscorePrefixedVariableName)
- [Style/UnneededInterpolation](http://www.rubydoc.info/github/bbatsov/RuboCop/RuboCop/Cop/Style/UnneededInterpolation)
- [Performance/RedundantBlockCall](http://www.rubydoc.info/github/bbatsov/RuboCop/RuboCop/Cop/Performance/RedundantBlockCall)
- [Layout/MultilineOperationIndentation](http://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Layout/MultilineOperationIndentation)
- Updated CHANGELOG.md to include recent bugfixes and 1.0.0 (forgotten) breaking changes
jsantos
force-pushed
the
bugfix/pidfiles_are_not_being_accounted_correctly
branch
from
7303e7b
to
e6ffa33
Compare
|
@seuros Done! |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #191
This regression was introduced by #190, due to a minor refactor on the method to retrieve the pidfiles for a particular host's roles.
In sum, the
sidekiq_rolesvariable was being mutated by a.reject!statement and would only work properly for the first method call (for more context check the corresponding issue).I took the liberty to do a few styling corrections, suggested by Rubocop. Also included the breaking change from
sidekiq_roletosidekiq_rolesthat happened on1.0.0to the corresponding changelog entry.