Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored template_sidekiq method #90

Merged
merged 1 commit into from
Jun 25, 2015

Conversation

rstrobl
Copy link
Contributor

@rstrobl rstrobl commented Jun 25, 2015

  • removed unused filenames
  • use File.join for referring to original template
  • removed some redundancy
  • split template_sidekiq into two separate methods for generating filename and uploading file


search_paths << global_search_path

search_paths.each { |path| return File.read(path) if File.file?(path) }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

search_paths.detect { |path| File.file?(path) }

@rstrobl rstrobl force-pushed the refactor_template_sidekiq_method branch from 729a8c6 to 8f8d04b Compare June 25, 2015 21:12
seuros added a commit that referenced this pull request Jun 25, 2015
@seuros seuros merged commit 7bc7310 into seuros:master Jun 25, 2015
@seuros
Copy link
Owner

seuros commented Jun 25, 2015

💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants