forked from reactjs/fa.react.dev
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync #3
Merged
Merged
sync #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When copy and pasting `npm install jest-cli —save-dev` you get this error `Invalid tag name "—save-dev": Tags may not have any characters that encodeURIComponent encodes` I replaced the unicode characters '—' with ascii hypens '-'
You can just normal install `eslint-plugin-react-hooks`
Fixes typo flexiblity
* Fix the link so that it navigates to anchor rather * Update create-a-new-react-app.md
Add this functionality with gatsby-remark-external-links plugin
* add React Boston 2019 to conference page * add massachusetts to react-boston listing
This conflict has been resolved in PR#54 before
* Fix anchor link offset with fixed header * handle h3 too * h4 as an anchor * don't affect UI by any means * no need for px * more fixes * consistency * more consistency * pixel perfection * fix h4 after gatsby-highlight * final touch
The link should probably either go to directly to the beginning of main concepts (which is what my proposes change does), or to the anchor -tag of "Step-by-Step Guide" (#step-by-step-guide). There is no other link in the article which refers to another anchor-tag, that's why I chose to directly link to the main-concepts.
Also add Mongolian and Catalan.
Sync with reactjs.org @ 4244fc6
Sync with reactjs.org @ 6bc6e7b
…st. (#1959) * previous page link is not linking to the previous page, but to the second last. The example code is on both, the `Introducing Hooks` as well as `Hooks at a Glance` page, but the linked page is the `Introducing Hooks` and I think that's the right one (the `Hooks at a Glance` page probably got added later?). Not sure about the phrasing so, having "introduce" twice in one sentence ... * Update content/docs/hooks-state.md Co-Authored-By: 0xnoob <49793844+0xnoob@users.noreply.github.com> Co-authored-by: Alexey Pyltsyn <lex61rus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.