Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync #3

Merged
merged 30 commits into from
May 7, 2019
Merged

sync #3

merged 30 commits into from
May 7, 2019

Conversation

seven-deuce
Copy link
Owner

No description provided.

bebraw and others added 30 commits April 23, 2019 12:07
When copy and pasting `npm install jest-cli —save-dev` you get this error
`Invalid tag name "—save-dev": Tags may not have any characters that encodeURIComponent encodes`

I replaced the unicode characters '—' with ascii hypens '-'
You can just normal install `eslint-plugin-react-hooks`
* Fix the link so that it navigates to anchor rather

* Update create-a-new-react-app.md
Add this functionality with gatsby-remark-external-links plugin
* add React Boston 2019 to conference page

* add massachusetts to react-boston listing
This conflict has been resolved in PR#54 before
* Fix anchor link offset with fixed header

* handle h3 too

* h4 as an anchor

* don't affect UI by any means

* no need for px

* more fixes

* consistency

* more consistency

* pixel perfection

* fix h4 after gatsby-highlight

* final touch
The link should probably either go to directly to the beginning of main concepts (which is what my proposes change does), or to the anchor  -tag of "Step-by-Step Guide" (#step-by-step-guide). There is no other link in the article which refers to another anchor-tag, that's why I chose to directly link to the main-concepts.
Also add Mongolian and Catalan.
…st. (#1959)

* previous page link is not linking to the previous page, but to the second last.

The example code is on both, the `Introducing Hooks` as well as `Hooks at a Glance` page, but the linked page is the `Introducing Hooks` and I think that's the right one (the `Hooks at a Glance` page probably got added later?).

Not sure about the phrasing so, having "introduce" twice in one sentence ...

* Update content/docs/hooks-state.md

Co-Authored-By: 0xnoob <49793844+0xnoob@users.noreply.github.com>


Co-authored-by: Alexey Pyltsyn <lex61rus@gmail.com>
@seven-deuce seven-deuce merged commit d9f7909 into seven-deuce:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.