fix: OffsetPositionConverter for emoji

seven332 · Nov 12, 2023 · 53af1c0 · 53af1c0
1 parent 78900c7
commit 53af1c0
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/integration-test/diagnostics.test.ts b/integration-test/diagnostics.test.ts
@@ -14,6 +14,16 @@ suite('Diagnostics', () => {
             },
         ])
     })
+
+    test('error diagnostics', async () => {
+        await testDiagnostics('error.sksl', [
+            {
+                message: "'main' must return: 'vec4', 'float4', or 'half4'",
+                range: toRange(3, 0, 3, 11),
+                severity: vscode.DiagnosticSeverity.Error,
+            },
+        ])
+    })
 })
 
 async function testDiagnostics(name: string, expected: vscode.Diagnostic[]) {

diff --git a/integration-test/fixtures/error.sksl b/integration-test/fixtures/error.sksl
@@ -0,0 +1,4 @@
+// kind=shader
+// 中文
+// 😋😋
+void main() {}
diff --git a/src/offset-position-converter.ts b/src/offset-position-converter.ts
@@ -10,7 +10,8 @@ export class OffsetPositionConverter {
 
         let index = 0
         let prev = ' '
-        for (const c of content) {
+        for (let i = 0; i < content.length; ++i) {
+            const c = content.charAt(i)
             switch (c) {
                 case '\n':
                     if (prev == '\n') {