Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Places to express closure captures #24

Closed
wants to merge 4 commits into from
Closed

Use Places to express closure captures #24

wants to merge 4 commits into from

Conversation

arora-aman
Copy link
Member

@arora-aman arora-aman commented Oct 5, 2020 •
edited by Azhng
Loading

This change is Reviewable

@arora-aman
Copy link
Member Author

arora-aman commented Oct 5, 2020 •
edited
Loading

@null-sleep The FIXME(azhng) probably should be replaced with something like: https://github.com/sexxi-goose/rust/blob/min_capture/compiler/rustc_typeck/src/check/upvar.rs#L750-L771

Though this should also account for Pattern expressions as we had discussed.

image

@arora-aman
Copy link
Member Author

arora-aman commented Oct 5, 2020 •
edited
Loading

I extracted the example programs we wrote for our 463 specification here: http://csclub.uwaterloo.ca/~a52arora/test_suite/spec/

The ones marked imp are the important ones, the numbers are just assocaited with the example number from the spec.

We also what to make sure that the cases mentioned in rust-lang/project-rfc-2229#9 (comment) are also added.

@arora-aman
Copy link
Member Author

@null-sleep I missed this change when I ported the change to the new compiler structure.
https://github.com/sexxi-goose/rust/blob/use_places_aman/src/librustc_typeck/check/upvar.rs#L425-L430

@null-sleep null-sleep force-pushed the use_places_new branch 2 times, most recently from a479185 to 18669ef Compare October 9, 2020 04:32
@arora-aman arora-aman force-pushed the use_places_new branch 2 times, most recently from 73e2d45 to 46a94d6 Compare October 13, 2020 17:35
arora-aman and others added 2 commits October 16, 2020 22:46
@arora-aman @Azhng
Use Places to express closure/generator Captures
16bef5c 
Co-authored-by: Archer Zhang <archer.xn@gmail.com>
@arora-aman
Indroduce feature flag for RFC-2229
08b85c8 
Signed-off-by: Aman Arora <me@aman-arora.com>
@arora-aman arora-aman force-pushed the use_places_new branch 2 times, most recently from 86ce8d9 to 9a48595 Compare October 17, 2020 05:55
@arora-aman @null-sleep
Add initial set of testcases for RFC 2229
1209375 
Co-authored-by: Dhruv Jauhar <dhruvjhr@gmail.com>
@null-sleep
Copy link

image

@arora-aman @null-sleep
Add helper function for Capture Esclations and expressions
fc836d0 
Co-authored-by: Dhruv Jauhar <dhruvjhr@gmail.com>
@arora-aman
Copy link
Member Author

#28

@arora-aman arora-aman closed this Oct 27, 2020
@arora-aman arora-aman deleted the use_places_new branch November 17, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arora-aman @null-sleep