Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keys get stuck when profile is changed while being held #296

Closed
DreadPirateLynx opened this issue Feb 11, 2022 · 4 comments
Closed

keys get stuck when profile is changed while being held #296

DreadPirateLynx opened this issue Feb 11, 2022 · 4 comments
Assignees

Comments

@DreadPirateLynx
Copy link

After getting my input-remapper-manager working, I quickly ran into a problem: anything making use of h() or m() never completes if the profile changes while the key is being held down. This is causing keys to get stuck and devices to act unpredictably.

@sezanzeb
Copy link
Owner

@jonasBoss would it be possible to add __del__ to the mapping handlers to handle those cases and release everything?

@jonasBoss
Copy link
Collaborator

yeah should I will note it in my Todo

@sezanzeb
Copy link
Owner

sezanzeb commented Feb 12, 2022

nice. I'll avoid redundantly doing those fixes on main for the old system then. Looking forward to the end result!

jonasBoss added a commit to jonasBoss/key-mapper that referenced this issue Apr 10, 2022
release any keys or buttons before the event pipeline shuts down
@jonasBoss
Copy link
Collaborator

fixed by the reset method in mapping handlers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants