We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ima/packages/core/src/page/renderer/ClientPageRenderer.js
Lines 119 to 126 in 646d467
The unmount event is never called, since ReactDOM.unmountComponentAtNode does not take second argument (https://reactjs.org/docs/react-dom.html#unmountcomponentatnode, https://github.com/facebook/react/blob/60016c448bb7d19fc989acd05dda5aca2e124381/packages/react-dom/src/client/ReactDOMLegacy.js#L340). Does this cause any bugs, or can we just remove it?
The text was updated successfully, but these errors were encountered:
fix: 🐛 $IMA.$PageRenderer.unmounted call on page unmount
544aacd
Closes: #50
Successfully merging a pull request may close this issue.
ima/packages/core/src/page/renderer/ClientPageRenderer.js
Lines 119 to 126 in 646d467
The unmount event is never called, since ReactDOM.unmountComponentAtNode does not take second argument (https://reactjs.org/docs/react-dom.html#unmountcomponentatnode, https://github.com/facebook/react/blob/60016c448bb7d19fc989acd05dda5aca2e124381/packages/react-dom/src/client/ReactDOMLegacy.js#L340). Does this cause any bugs, or can we just remove it?
The text was updated successfully, but these errors were encountered: