Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from lazy_static to once_cell #1399

Closed
jplatte opened this issue Dec 30, 2020 · 3 comments · Fixed by #1400
Closed

Switch from lazy_static to once_cell #1399

jplatte opened this issue Dec 30, 2020 · 3 comments · Fixed by #1400

Comments

@jplatte
Copy link
Contributor

jplatte commented Dec 30, 2020

Other crates are slowly moving from lazy_static to once_cell, notably tokio did so in 0.3. Would you accept a PR that does the same thing for this crate?
@sfackler
Copy link
Owner

Assuming it builds on Rust 1.34, sure!

@jplatte
Copy link
Contributor Author

jplatte commented Dec 30, 2020

Hrm, apparently the current release has an MSRV of 1.36.0 and MSRV updates are not considered breaking changes like for many other crates (including lazy_static). Would that MSRV bump be a big deal to you?

@sfackler
Copy link
Owner

I tend to bump the MSRV as dependencies do. Going to 1.36 seems fine. You'll just need to tweak this line in the PR: https://github.com/sfackler/rust-openssl/blob/master/.github/workflows/ci.yml#L66

@jplatte jplatte mentioned this issue Dec 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch from lazy_static to once_cell
2 participants
@jplatte @sfackler