Switch from lazy_static to once_cell #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also changes the MSRV from 1.34.0 to 1.36.0.
Yes please! |
sfackler
reviewed
Dec 31, 2020
openssl/src/ssl/connector.rs
Outdated
| pub static ref HOSTNAME_IDX: Index<Ssl, String> = Ssl::new_ex_index().unwrap(); | ||
| } | ||
| pub static HOSTNAME_IDX: Lazy<Index<Ssl, String>> = | ||
| Lazy::new(|| Ssl::new_ex_index().unwrap()); |
There was a problem hiding this comment.
If you use use a OnceCell instead you can use get_or_try_init to avoid the unwrap here: https://docs.rs/once_cell/1.5.2/once_cell/sync/struct.OnceCell.html#method.get_or_try_init
so some initialization errors don't result in a panic.
sfackler
reviewed
Dec 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also changes the MSRV from 1.34.0 to 1.36.0.
Closes #1399.
Looks like with both the old and new MSRV, the crate could also switch to edition 2018. Would you like another PR for that?