Mismatched Rust types at X509 bindings with BoringSSL on Windows 10

[HMaker]

I am getting the following compiler error when trying to link rust-openssl against BoringSSL (commit f78fe19fc98e0e6f760e05c6b9d48725004700d0, same from CI) on Windows 10:

D:\Users\heraldo\projects\rust-openssl>cargo build -r --package openssl
warning: expando.c
   Compiling openssl v0.10.61 (D:\Users\heraldo\projects\rust-openssl\openssl)
error[E0308]: mismatched types
   --> openssl\src\x509\mod.rs:764:62
    |
764 |                     if ffi::ERR_GET_LIB(err) as X509LenTy == ffi::ERR_LIB_PEM
    |                        ----------------------------------    ^^^^^^^^^^^^^^^^ expected `u32`, found `i32`
    |                        |
    |                        expected because this is `u32`
    |
help: you can convert an `i32` to a `u32` and panic if the converted value doesn't fit
    |
764 |                     if ffi::ERR_GET_LIB(err) as X509LenTy == ffi::ERR_LIB_PEM.try_into().unwrap()
    |                                                                              ++++++++++++++++++++

For more information about this error, try `rustc --explain E0308`.
error: could not compile `openssl` (lib) due to previous error

D:\Users\heraldo\projects\rust-openssl>

My Rust version is:

D:\Users\heraldo\projects\rust-openssl>rustc --version
rustc 1.73.0 (cc66ad468 2023-10-03)

D:\Users\heraldo\projects\rust-openssl>cargo --version
cargo 1.73.0 (9c4383fb5 2023-08-26)

[alex]

@sfackler do you remember why the cast is written in that strange way? Otherwise I'll probably just rewrite it to go via ErrorStack

[sfackler]

No, that cast seems suspicious to me as well.

[alex]

@HMaker can you verify if #2120 fixes it for you?

[HMaker]

Now the openssl package builds, but when trying to build all packages I got the following compiler errors

error[E0432]: unresolved imports `openssl_sys::ERR_load_strings`, `openssl_sys::ERR_PACK`, `openssl_sys::ERR_STRING_DATA`
  --> openssl-errors\src\lib.rs:60:43
   |
60 |         init, ERR_get_next_error_library, ERR_load_strings, ERR_PACK, ERR_STRING_DATA,
   |                                           ^^^^^^^^^^^^^^^^  ^^^^^^^^  ^^^^^^^^^^^^^^^ no `ERR_STRING_DATA` in the root
   |                                           |                 |
   |                                           |                 no `ERR_PACK` in the root
   |                                           no `ERR_load_strings` in the root
   |
help: a similar name exists in the module
   |
60 |         init, ERR_get_next_error_library, ERR_load_BIO_strings, ERR_PACK, ERR_STRING_DATA,
   |                                           ~~~~~~~~~~~~~~~~~~~~
help: a similar name exists in the module
   |
60 |         init, ERR_get_next_error_library, ERR_load_strings, ERR_PACK, PEM_STRING_DSA,
   |                                                                       ~~~~~~~~~~~~~~

error[E0308]: mismatched types
    --> openssl-errors\src\lib.rs:169:17
     |
164  |             openssl_sys::ERR_put_error(
     |             -------------------------- arguments to this function are incorrect
...
169  |                 line as c_int,
     |                 ^^^^^^^^^^^^^ expected `u32`, found `i32`
     |
note: function defined here
    --> D:\Users\heraldo\projects\rust-openssl-alex\target\release\build\openssl-sys-dc144e27d7f73006\out/bindgen.rs:5298:12
     |
5298 |     pub fn ERR_put_error(
     |            ^^^^^^^^^^^^^
help: you can convert an `i32` to a `u32` and panic if the converted value doesn't fit
     |
169  |                 (line as c_int).try_into().unwrap(),
     |                 +             +++++++++++++++++++++

Some errors have detailed explanations: E0308, E0432.
For more information about an error, try `rustc --explain E0308`.
error: could not compile `openssl-errors` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...

[alex]

The openssl-errors crate isn't supported on boringssl. What do you need it for?

[HMaker]

I don't need it, I thought it was another compiler error. So it's fixed, thanks!

[alex]

Great!

…

On Wed, Dec 6, 2023 at 4:45 PM Heraldo Lucena ***@***.***> wrote: I don't need it, I thought it was another compiler error. So it's fixed, thanks! — Reply to this email directly, view it on GitHub <#2119 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAGBEREG3T3JLB2J2AYITYIDROHAVCNFSM6AAAAABAJ7YDXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBTG4ZTSNRQGY> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

-- All that is necessary for evil to succeed is for good people to do nothing.