I made it to recognize macport openssl library. #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modification will resolve sfackler#976.
sfackler
reviewed
May 8, 2020
openssl-sys/build/find_normal.rs
Outdated
| @@ -50,6 +50,10 @@ fn find_openssl_dir(target: &str) -> OsString { | |||
| return homebrew.to_path_buf().into(); | |||
| } | |||
| } | |||
| let port_out = get_macport_openssl(); | |||
| if !port_out.is_empty() { | |||
There was a problem hiding this comment.
It's generally preferable to use an Option to track optional data than the emptyness of a string, IMO.
I used Option to find macport openssl path.
sfackler
reviewed
Nov 15, 2020
openssl-sys/build/find_normal.rs
Outdated
| let version = get_macport_openssl_version(outputs); | ||
|
|
||
| if version.is_some() | ||
| && version.unwrap() >= std::string::String::from("@1.1") { |
There was a problem hiding this comment.
Trying to compare versions as strings seems suspicious.
There was a problem hiding this comment.
I revised some lines to compare version rather than string. I chose the way to write simple version struct for mac port openssl rather than rust semver. Semver did not parse mac port openssl version like "1.1.1h".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modification will resolve #976.