Print out a version directive for OpenSSL 3.0.0 #1548
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was printed out for previous OpenSSL versions for downstream consumers but it looks like this was accidentally omitted for the 3.0.0 branch.
alexcrichton
added a commit
to alexcrichton/curl-rust
that referenced
this pull request
Nov 1, 2021
This commit should fix an issue that showed up in rust-lang/cargo#10013 where curl's initialization was accidentally detecting that curl needed an early initialization (due to sfackler/rust-openssl#1548). This early initialization caused the later env-vars set by `openssl-probe` to not actually be read since OpenSSL was already initialized. While not an issue for `curl` I think it does pose an issue for other libraries like libgit2 using OpenSSL. The fix here is to initialize the env vars before OpenSSL, which should have OpenSSL pick up the probe results.
|
I think this was actually intentional - the recommended way to check what version you're linking against is to load the exact version from Example: https://github.com/sfackler/rust-openssl/blob/master/openssl-errors/build.rs |
|
Ah ok makes sense! I'll update these lines to use that instead. |
alexcrichton
added a commit
to alexcrichton/curl-rust
that referenced
this pull request
Nov 1, 2021
As described in sfackler/rust-openssl#1548
alexcrichton
added a commit
to alexcrichton/curl-rust
that referenced
this pull request
Nov 1, 2021
As described in sfackler/rust-openssl#1548
alexcrichton
added a commit
to alexcrichton/curl-rust
that referenced
this pull request
Nov 2, 2021
This commit should fix an issue that showed up in rust-lang/cargo#10013 where curl's initialization was accidentally detecting that curl needed an early initialization (due to sfackler/rust-openssl#1548). This early initialization caused the later env-vars set by `openssl-probe` to not actually be read since OpenSSL was already initialized. While not an issue for `curl` I think it does pose an issue for other libraries like libgit2 using OpenSSL. The fix here is to initialize the env vars before OpenSSL, which should have OpenSSL pick up the probe results.
alexcrichton
added a commit
to alexcrichton/curl-rust
that referenced
this pull request
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was printed out for previous OpenSSL versions for downstream
consumers but it looks like this was accidentally omitted for the 3.0.0
branch.