check for libraries in lib64, if it exists #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
messense
reviewed
Dec 14, 2021
sfackler
reviewed
Dec 26, 2021
| let mut lib_dirs = vec![]; | ||
| // OpenSSL 3.0 now puts it's libraries in lib64/ by default, | ||
| // check for both it and lib/. | ||
| if openssl_dir.join("lib64").exists() { |
There was a problem hiding this comment.
It should be fine to just unconditionally return both paths I think.
There was a problem hiding this comment.
That's how I originally wrote the code, but then determine_kind calls read_dir on it and I'd have to add error handling there so just checking for existence on the front seemed easier and more consistent.
There was a problem hiding this comment.
Ugh, determine_kind is such an unfortunate function...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1581