Add a dummy bn_is_zero C dependency to wrap BN_is_zero #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary because on some architectures BN_is_zero is a CPP macro, so trying to link against it in an `extern "C"` block causes a linker error. This also introduces a build command to Cargo to compile the bn_is_zero wrapper.
|
Will the compiler automatically link in the .o? |
|
Cargo will automatically include anything that you put in the |
|
Man, OpenSSL's API is such a mess :( Thanks! |
sfackler
added a commit
that referenced
this pull request
Oct 5, 2014
Add a dummy bn_is_zero C dependency to wrap BN_is_zero
|
@sfackler Ya, this is extremely gross, but unfortunately necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary because on some architectures BN_is_zero
is a CPP macro, so trying to link against it in an
extern "C"block causes a linker error.
This also introduces a build command to Cargo to compile
the bn_is_zero wrapper.