Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build openssl in parallel #729

Closed
wants to merge 1 commit into from

Conversation

aidanhs
Copy link
Contributor

@aidanhs aidanhs commented Sep 17, 2017

See rust-lang/rust#41563 - historically it's caused problems, and although it should be better in 1.1 I'm still not sure I'd recommend it. Up to you.

@sfackler
Copy link
Owner

I'd just change the line to make - it matches up with openssl's own INSTALL file.

@aidanhs
Copy link
Contributor Author

aidanhs commented Sep 18, 2017

The problem with that is the MAKEFLAGS environment variable, which is the way it caused problems in Rust. My concern was that people are going to put this into scripts called by other scripts (e.g. openssl-src-rs) that then inherit any parallelism flags.

However, I've looked back through the issues and it appears openssl has put reasonable some work into making parallel builds not break. Realistically the only consumer to see this will be Rust itself and we'll know what caused as soon as it happens, so let's just let this percolate back to Rust via openssl-src-rs and see what happens.

cc @alexcrichton for the record.

@aidanhs aidanhs closed this Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants