Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take IntoIterator rather than &[&ToSql]. #265

Closed
sfackler opened this issue Jun 8, 2017 · 1 comment · Fixed by #458
Closed

Take IntoIterator rather than &[&ToSql]. #265

sfackler opened this issue Jun 8, 2017 · 1 comment · Fixed by #458

Comments

@sfackler
Copy link
Owner

sfackler commented Jun 8, 2017

It might be pretty tricky to figure out the exact bounds that will work, but we don't need a slice of &ToSql specifically.
@sfackler sfackler mentioned this issue Jun 8, 2017
Open
@gwenn gwenn mentioned this issue Sep 10, 2018
Closed
@gwenn gwenn mentioned this issue Dec 17, 2018
Closed
@elpiel
Copy link
Contributor

elpiel commented Jun 13, 2019

Can you give a bit more information, I would like to try and implement this?

@sfackler sfackler mentioned this issue Jun 20, 2019
Closed
@kaibyao kaibyao mentioned this issue Jun 21, 2019
Closed
sfackler added a commit that referenced this issue Jul 10, 2019
@sfackler
Add methods that take iterators of parameters
8192c77 
The existing methods which take slices of parameters work well when
directly passing a temporary slice (e.g. `c.query(s, &[&15, &"hi"])`,
but becomes limiting in other contexts like when programmatically
building up a query. We now offer methods which take iterators, which
are significantly more flexible for these kinds of use cases.

Because of the weird object safety of `ToSql`, we can't be generic over
`Iterator<Item = impl ToSql>`, but instead have to specifically work
with `Iterator<Item = &dyn ToSql>`. This may require a `.map()` or two
but should still work fine.

Closes #265
@sfackler sfackler mentioned this issue Jul 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add methods that take iterators of parameters sfackler/rust-postgres
2 participants
@sfackler @elpiel