Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReadOnly in TargetSessionAttrs #1110

Merged

Conversation

chandr-andr
Copy link
Contributor

@chandr-andr chandr-andr commented Mar 3, 2024

Hi!
I've found that there is no option to set read-only in target-session-attrs for connection to PostgreSQL.
Please, take a look at this pull request.

@@ -34,6 +34,8 @@ pub enum TargetSessionAttrs {
Any,
/// The session must allow writes.
ReadWrite,
/// The session allow only reads.
ReadOnly,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This presumably needs to be used somewhere in the connection code.

Copy link
Contributor Author

@chandr-andr chandr-andr Mar 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfackler Sry, haven't committed my latest changes. Please have a look.

@sfackler sfackler merged commit d6c2835 into sfackler:master Mar 3, 2024
4 checks passed
@sfackler
Copy link
Owner

sfackler commented Mar 3, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants