Fail safe error message akka#3253

1. Make sure we don't emit empty string 2. correct configuration
sfali · Sep 10, 2024 · 948db31 · 948db31
1 parent 9fb81d1
commit 948db31
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/azure-storage/src/main/scala/akka/stream/alpakka/azure/storage/StorageException.scala b/azure-storage/src/main/scala/akka/stream/alpakka/azure/storage/StorageException.scala
@@ -64,10 +64,11 @@ object StorageException {
       )
     } match {
       case Failure(ex) =>
+        val errorMessage = emptyStringToOption(ex.getMessage)
         StorageException(
           statusCode = statusCode,
-          errorCode = Option(ex.getMessage).getOrElse("null"),
-          errorMessage = Option(response).getOrElse("null"),
+          errorCode = errorMessage.getOrElse("null"),
+          errorMessage = emptyStringToOption(response).orElse(errorMessage).getOrElse("null"),
           resourceName = None,
           resourceValue = None,
           reason = None

diff --git a/azure-storage/src/test/resources/application.conf b/azure-storage/src/test/resources/application.conf
@@ -13,10 +13,8 @@ azurite {
 
 akka {
   http {
-    client {
-      parsing {
-        max-response-reason-length = 512
-      }
+    parsing {
+      max-response-reason-length = 512
     }
   }
 }