Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scale command #58

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Fix scale command #58

merged 1 commit into from
Jan 28, 2025

Conversation

scaredginger
Copy link
Contributor

No description provided.

@scaredginger scaredginger requested a review from Sladuca January 28, 2025 00:34
Copy link

semanticdiff-com bot commented Jan 28, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  src/lib/updown.tsx  3% smaller

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR updates the scale command to align with the current API schema, focusing on procurement-related property names and request structures.

  • Changed instance_group to instance_type in /src/lib/updown.tsx to match API schema
  • Added missing fields in procurement update requests for API compatibility
  • Removed deprecated block_duration_in_hours field from request payload
  • Updated procurement operations to use correct property names for API calls
  • Fixed parameter validation to match current API requirements

💡 (5/5) You can turn off certain types of comments like style here!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@scaredginger scaredginger merged commit 5fd6a76 into main Jan 28, 2025
1 check passed
@scaredginger scaredginger deleted the ak/scale-fixes branch January 28, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants