Kenny/serial number as filename #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a static filename, the server configuration is now saved
using the server's chassis serial number. This helps identify which
configuration belongs to which physical server and prevents accidental
overwrites when collecting data from multiple servers.
Changes:
- Added filename sanitization function to handle invalid characters
- Replaced static server_config.toml with dynamic {serial_number}.toml
- Updated user feedback messages to show actual filename being used
Example output: ABC123DEF456.toml instead of server_config.toml
Instead of using a static filename, the server configuration is now saved
using the server's chassis serial number. This helps identify which
configuration belongs to which physical server and prevents accidental
overwrites when collecting data from multiple servers.
Changes:
- Added filename sanitization function to handle invalid characters
- Replaced static server_config.toml with dynamic {serial_number}.toml
- Updated user feedback messages to show actual filename being used
Example output: ABC123DEF456.toml instead of server_config.toml
Instead of using a static filename, the server configuration is now saved
using the server's chassis serial number. This helps identify which
configuration belongs to which physical server and prevents accidental
overwrites when collecting data from multiple servers.
Changes:
- Added filename sanitization function to handle invalid characters
- Replaced static server_config.toml with dynamic {serial_number}.toml
- Updated user feedback messages to show actual filename being used
Example output: ABC123DEF456.toml instead of server_config.toml
jeztek
pushed a commit
that referenced
this pull request
Nov 27, 2024
Kenny/serial number as filename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Use chassis serial number with hw_report suffix for configuration file
Description
Changes the configuration output filename from a static
server_config.tomlto a dynamic<chassis_serial_number>_hw_report.tomlformat. This helps identify which physical serverthe configuration belongs to and indicates the file's purpose.
Changes Made
Example
Before:
server_config.tomlAfter:
ABC123DEF456_hw_report.tomlTesting Done
Related Issues
Closes Linear ticket: https://linear.app/sfcompute/issue/ENG-920/modify-filename-of-hardware-report-output
Checklist