Add test for parsing frozen string and fixed related bug (#52)

sferik · Dec 6, 2016 · 0c280a7 · 0c280a7
1 parent 47ec807
commit 0c280a7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/multi_xml.rb b/lib/multi_xml.rb
@@ -131,7 +131,7 @@ def parse(xml, options = {}) # rubocop:disable AbcSize, CyclomaticComplexity, Me
 
       options = DEFAULT_OPTIONS.merge(options)
 
-      xml.strip! if xml.respond_to?(:strip!)
+      xml = xml.strip if xml.respond_to?(:strip)
       begin
         xml = StringIO.new(xml) unless xml.respond_to?(:read)
 

diff --git a/spec/parser_shared_example.rb b/spec/parser_shared_example.rb
@@ -32,6 +32,16 @@
       end
     end
 
+    context 'a frozen string' do
+      before do
+        @xml = ' '.freeze
+      end
+
+      it 'returns an empty Hash' do
+        expect(MultiXml.parse(@xml)).to eq({})
+      end
+    end
+
     unless parser == 'Oga'
       context 'an invalid XML document' do
         before do