Use a guard clause instead of wrapping the code inside a conditional …

…expression
sferik · Dec 6, 2016 · 534f558 · 534f558
1 parent 5ca8fe0
commit 534f558
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/lib/multi_xml/parsers/rexml.rb b/lib/multi_xml/parsers/rexml.rb
@@ -15,11 +15,8 @@ def parse_error
       #   XML Document IO to parse
       def parse(xml)
         doc = REXML::Document.new(xml)
-        if doc.root
-          merge_element!({}, doc.root)
-        else
-          raise(REXML::ParseException.new("The document #{doc.to_s.inspect} does not have a valid root"))
-        end
+        raise(REXML::ParseException.new("The document #{doc.to_s.inspect} does not have a valid root")) unless doc.root
+        merge_element!({}, doc.root)
       end
 
     private