Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add to work with async await module #7

Closed
wants to merge 7 commits into from

Conversation

frani
Copy link

@frani frani commented Oct 15, 2020

HI Shane, here is a resumen of changes:

  • created module that work with async/await
  • created module that test async/await module
  • fix deprecated method
  • fix variables name and replace 'var' for 'let'

@frani
Copy link
Author

frani commented Oct 15, 2020

ups I see I was using different eslint config - I will fix later.

Copy link
Owner

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I changed my mind about backwards compatibility. I think we should bump the major version number and have async/await as the only API. If people can't use async/await, then they can use an older version of the library.

Can you please:

  1. Undo all the unnecessary formatting changes. Most of this PR is formatting changes, not code changes, and it makes it very difficult to review.
  2. Either remove the non-async/await code paths or make them wrap the old code paths (don't duplicate code).
  3. Update the README file with new documentation.

.travis.yml Outdated Show resolved Hide resolved
Copy link
Owner

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, if you want to keep async/await in a separate namespace alongside the old-style code, that's fine. But, you shouldn't duplicate the code, as you appear to have done in this PR.

@@ -0,0 +1,83 @@
"use strict";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo the name change of this file, or make sure it is similar enough to the old file that Git sees it as a file move. (Also for handler.test.js)

@sffc
Copy link
Owner

sffc commented Dec 28, 2020

I'm closing this PR due to inactivity. Please reopen if you intend to continue with this change.

@sffc sffc closed this Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants