increase tidyeval usage #178
Conversation
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 20 20
Lines 601 600 -1
=====================================
- Hits 601 600 -1
|
|
Just taking a quick look, I think this is even better than the rebase. It looks like you used the current dev version of these functions as the base for your changes so it should be easily mergeable. I'll try to review this within the next week. I see changes like switching from deprecated |
how did I not figure this out originally?!
R/tabyl.R
Outdated
| combos <- tidyr::complete(tabl %>% dplyr::select(-n), !!!rlang::syms(names(tabl)[1:2])) # this is pretty ugly - using dplyr keeps col types the same making for easier join, vs. expand.grid | ||
| # would be nice to just complete() tabl and skip the join, but couldn't get the eval to work | ||
| tabl <- suppressMessages(dplyr::full_join(tabl, combos)) | ||
| tabl <- tidyr::complete(tabl, !! var1, !! var2) |
There was a problem hiding this comment.
@bfgray3 I don't remember all of my struggles originally with this but my comment indicates that this was a kludge but the best I could do. I seem to have succeeded in simplifying this as I'd originally hoped... it passes the tests so should be good but do you see any risks here?
There was a problem hiding this comment.
Nice work! Definitely much better than the update I had made. 👍
this is a replacement for #146. sorry for the confusion in that pull request.