Pipeline crosstab #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed crosstab.default to accept lists, expect_equal was also failing on the percent='all' test but shouldnt' have been.
Current coverage is 98.82%@@ master #34 diff @@
========================================
Files 9 9
Lines 151 170 +19
Methods 0 0
Messages 0 0
Branches 0 0
========================================
+ Hits 151 168 +17
- Misses 0 2 +2
Partials 0 0
|
|
Wow! Wizardry. I don't entirely follow and will need to do some reading to 100% understand, but it works great. The one question I have now is, I see when I start typing "crosstab" in RStudio I get "crosstab.data.frame" and "crosstab.default" suggested. Is it standard to export those? Is it possible some users will want to call them directly? I don't immediately see a purpose to exporting them. |
|
Your probably right regarding exporting them. I'll double check tomorrow and make changes as necessary. |
|
I don't think you generally export the functions that only do method dispatch. I think those stay internal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates an S3 generic for crosstab as well as default and
data.tablemethods. Thecrosstabis now pipeable. One side effect of this is I had to allowlistobjects as acceptable objects forvec1andvec2parameters in thecrosstab.default. (Essentially as a way to deal with NSE in both thecrosstab.data.frameandcrosstab.defaultmethods). I've updated the tests and the package is currently passing R CMD CHECK on my MBP.