Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where the sf package "sf_column" may not be the last column in an sf object #579

Conversation

billdenney
Copy link
Collaborator

@ar-puuk, can you please test this and confirm that it works for you. I'm not an sf package user, so I can just confirm that it prints correctly not that the rest of it works.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cd47202) to head (b052e2d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #579   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines         1401      1401           
=========================================
  Hits          1401      1401           
Files with missing lines Coverage Δ
R/clean_names.R 100.00% <100.00%> (ø)

@billdenney
Copy link
Collaborator Author

@sfirke, I think that this is ready to merge unless you have any comments on review.

Copy link
Owner

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sfirke
Copy link
Owner

sfirke commented Sep 12, 2024

Thanks Bill and Pukar!

@sfirke sfirke merged commit 709b2ab into main Sep 12, 2024
10 checks passed
@sfirke sfirke deleted the 578-clean_namessf-does-not-recognize-shape-column-as-a-sfc-column-when-it-contains-multiple-geometry-types branch September 12, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clean_names.sf() does not recognize SHAPE column as a sfc column when it contains multiple Geometry Types
2 participants