Alternative referencing scheme for focused sources in WFS #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered an issue regarding the existing referencing scheme for the focused source in WFS, namely
reference_point
andreference_line
.Reference Point:
Reference Line:
Both schemes have the drawback, that the denominator can become zero for non-pathological cases. Hence particular secondary sources have a unreasonably high amplitude. I added a scheme called
reference_circle
which ensure amplitude correct synthesis on a circle around the focused source, which does not have these issues. Please execute the following example to comparereference_point
andreference_circle
. The green dots in the plots forreference_point
indicate the theoretical coordinates on the circular SSD, where the amplitude of the seconday source is infinity.