Rebase and use the swap and pop helper

sfztools · Jun 15, 2020 · cd0b715 · cd0b715
1 parent 605f08f
commit cd0b715
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 20 deletions.
diff --git a/src/sfizz/PolyphonyGroup.h b/src/sfizz/PolyphonyGroup.h
@@ -1,6 +1,7 @@
 #pragma once
 #include "Region.h"
 #include "Voice.h"
+#include "SwapAndPop.h"
 #include "absl/algorithm/container.h"
 
 namespace sfz
@@ -20,15 +21,7 @@ class PolyphonyGroup {
     }
     void removeVoice(const Voice* voice)
     {
-        auto it = absl::c_find(voices, voice);
-        if (it == voices.end())
-            return;
-
-        auto last = voices.end() - 1;
-        if (it != last)
-            std::iter_swap(it, last);
-
-        voices.pop_back();
+        swapAndPopFirst(voices, [voice](const Voice* v) { return v == voice; });
     }
     const std::vector<Voice*>& getActiveVoices() const { return voices; }
     std::vector<Voice*>& getActiveVoices() { return voices; }

diff --git a/src/sfizz/RegionSet.h b/src/sfizz/RegionSet.h
@@ -1,6 +1,7 @@
 #pragma once
 #include "Region.h"
 #include "Voice.h"
+#include "SwapAndPop.h"
 #include <vector>
 
 namespace sfz
@@ -31,16 +32,7 @@ class RegionSet {
     }
     void removeVoice(const Voice* voice)
     {
-        auto it = absl::c_find(voices, voice);
-        if (it == voices.end())
-            return;
-
-        auto last = voices.end() - 1;
-        if (it != last)
-            std::iter_swap(it, last);
-
-        voices.pop_back();
-        DBG("Active voices size " << voices.size());
+        swapAndPopFirst(voices, [voice](const Voice* v) { return v == voice; });
     }
     static void registerVoiceInHierarchy(const Region* region, Voice* voice)
     {

diff --git a/src/sfizz/Synth.cpp b/src/sfizz/Synth.cpp
@@ -51,7 +51,6 @@ void sfz::Synth::onVoiceStateChanged(NumericId<Voice> id, Voice::State state)
     (void)state;
     if (state == Voice::State::idle) {
         auto voice = getVoiceById(id);
-        DBG("Removing voice " << id.number << " from hierarchies");
         RegionSet::removeVoiceFromHierarchy(voice->getRegion(), voice);
         polyphonyGroups[voice->getRegion()->group].removeVoice(voice);
     }