Set loop_mode to one_shot for release regions

sfztools · Aug 18, 2020 · ed38c93 · ed38c93
1 parent be7ff64
commit ed38c93
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/sfizz/Region.cpp b/src/sfizz/Region.cpp
@@ -349,9 +349,11 @@ bool sfz::Region::parseOpcode(const Opcode& rawOpcode)
             break;
         case hash("release"):
             trigger = SfzTrigger::release;
+            loopMode = SfzLoopMode::one_shot;
             break;
         case hash("release_key"):
             trigger = SfzTrigger::release_key;
+            loopMode = SfzLoopMode::one_shot;
             break;
         default:
             DBG("Unknown trigger mode: " << opcode.value);

diff --git a/tests/RegionT.cpp b/tests/RegionT.cpp
@@ -497,10 +497,15 @@ TEST_CASE("[Region] Parsing opcodes")
         REQUIRE(region.trigger == SfzTrigger::attack);
         region.parseOpcode({ "trigger", "release" });
         REQUIRE(region.trigger == SfzTrigger::release);
+        REQUIRE(region.loopMode == SfzLoopMode::one_shot);
         region.parseOpcode({ "trigger", "first" });
         REQUIRE(region.trigger == SfzTrigger::first);
         region.parseOpcode({ "trigger", "legato" });
         REQUIRE(region.trigger == SfzTrigger::legato);
+        region.parseOpcode({ "loop_mode", "no_loop" });
+        region.parseOpcode({ "trigger", "release_key" });
+        REQUIRE(region.trigger == SfzTrigger::release_key);
+        REQUIRE(region.loopMode == SfzLoopMode::one_shot);
     }
 
     SECTION("on_locc, on_hicc")