Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note-On performance issue #1233

Closed
KKQ-KKQ opened this issue Feb 1, 2024 · 0 comments
Closed

Note-On performance issue #1233

KKQ-KKQ opened this issue Feb 1, 2024 · 0 comments

Comments

@KKQ-KKQ
Copy link
Contributor

KKQ-KKQ commented Feb 1, 2024

sfizz v1.2.3's performance when note-on is bad than v1.2.2.
I found that it is because absl::flat_hash_map<ModKey, uint32_t>::find() is slow.
This is because ModKey's hash function makes collisions.

I made a pull request #1232 .
@KKQ-KKQ KKQ-KKQ closed this as completed Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KKQ-KKQ