Improved Note-On performance #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found ModKey hash function doesn't process its region. |
paulfd
reviewed
Feb 2, 2024
|
Thanks a lot for the PR and for catching this! I will take some time to review it better hopefully this WE. I had another issue a long time ago where I also needed to cache the key/id hashes for lookups in the modulation matrix... |
|
Would it be okay that I reformat and squash the commits a bit to match the usual code style? I'll keep your authorship. |
|
No problem. |
paulfd
force-pushed
the
modkey-performance
branch
from
984588b to
debc013
Compare
- Compute the hash value on ModKey construction and memorize it - Fix missing region ID in the hash value of ModKey
paulfd
force-pushed
the
modkey-performance
branch
from
debc013 to
d96676b
Compare
|
No worries, thanks a lot! I mostly put all commits into a single one (which is called "squashing") to make it easier to follow the history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that calculating a hash of the ModKey is the bottleneck.
I added a variable to cache ModKey's hash.