Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noise print or denormal occur when ampeg_release not reached #373

Closed
kinwie opened this issue Aug 18, 2020 · 8 comments · Fixed by #734
Closed

Noise print or denormal occur when ampeg_release not reached #373

kinwie opened this issue Aug 18, 2020 · 8 comments · Fixed by #734
Assignees
Labels
bug Something isn't working

Comments

@kinwie
Copy link

kinwie commented Aug 18, 2020

When the ampeg_release stage not yet reached and the region ends, sfizz produce some kind of noise print of denormal after it.

@paulfd
Copy link
Member

paulfd commented Aug 18, 2020

There should be no denormals, so it might be noise or garbage. Do you have a test case?

@kinwie
Copy link
Author

kinwie commented Aug 19, 2020

Yes, tempo 120 bpm

<region>
sample=*sine
ampeg_attack=1
ampeg_hold=1
ampeg_decay=1
ampeg_sustain=0
ampeg_release=1

Draw one bar midi note, so it reach the release stage, no noise :
Untitled

Draw two bars note, it's not reach the release stage, there is noise after it (it should ends in the 2nd bar, 3rd beat, like first image) :
Untitled2

This seems only occur when the ampeg_sustain value is 0

@paulfd
Copy link
Member

paulfd commented Sep 22, 2020

Was this one improved this summer?

@paulfd paulfd added the bug Something isn't working label Sep 22, 2020
@paulfd paulfd self-assigned this Sep 22, 2020
@jpcima
Copy link
Collaborator

jpcima commented Sep 22, 2020

It's because we cut the envelope release at -60 dB.
You can lessen it by aiming at -80 dB.
If we rewrite the ADSR entirely in curves, there is no more need to take care of this asymptotic behavior.
(but then unnatural behavior on level/time dynamic updates. it's the ARIA behavior)

@paulfd
Copy link
Member

paulfd commented Sep 22, 2020

I think it could make sense to have the ampeg as a FlexEG too, if only to have a single codepath to check and optimize for all this.

@paulfd
Copy link
Member

paulfd commented Mar 21, 2021

@kinwie does this still happen? I have trouble seeing it on Reaper

@kinwie
Copy link
Author

kinwie commented Mar 22, 2021

@paulfd Using same example case as above, the release is cut shorter (sfizz - DropZone - sforzando)
Untitled

@jpcima
Copy link
Collaborator

jpcima commented Mar 22, 2021

A simple solution is to add a final phase that finishes the envelope in linear.

jpcima added a commit to jpcima/sfizz that referenced this issue Mar 22, 2021
jpcima added a commit to jpcima/sfizz that referenced this issue Mar 22, 2021
jpcima added a commit to jpcima/sfizz that referenced this issue Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants