Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with gcc-7 on linux (WIP) #1

Merged
merged 3 commits into from
Sep 16, 2019
Merged

Conversation

falkTX
Copy link
Contributor

@falkTX falkTX commented Sep 10, 2019

Not very clean, needs improvement.
But already gives you an idea of what is needed for compatibility

@paulfd
Copy link
Member

paulfd commented Sep 10, 2019

Hi, thanks. I like the latest version with the __has_include.

If you want to make it completely compatible with gcc-7 there will be some issues with <optional> and <string_view>. That being said, since I already rely on abseil, they provide c++11 versions of both and they default to the standard library when compiled with c++17. Maybe using absl::optional and absl::string_view everywhere would be easier for older compiler versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants