Changed the way the parser handles multiple parameters in opcodes #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpcima
reviewed
Mar 5, 2020
| if (absl::SimpleAtoi(opcode.substr(nextNumIndex, numDigits), &returnedValue)) { | ||
| // ASSERT(returnedValue < std::numeric_limits<uint8_t>::max()); | ||
| parameterPositions.push_back(parameterPosition); | ||
| lettersOnlyHash = hash("&", lettersOnlyHash); |
There was a problem hiding this comment.
The case that the invalid input contains "&" should be handled for safety.
Otherwise you could match a hash which doesn't have the required parameter count.
There was a problem hiding this comment.
So should we ignore these opcodes or just silently strip out the "&" from the opcode name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea from @jpcima :)
The resulting code is much cleaner and properly handles wrong positioning of parameters, with basically no cost. Also changed the parameters to be
u16to handle values larger than 256 for the CC number.