Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct a bug with dynamic updates on offed EGs #1088

Merged
merged 1 commit into from
Jun 26, 2022

Conversation

paulfd
Copy link
Member

@paulfd paulfd commented May 31, 2022

Closes: #2

@falkTX if you want to check that this indeed solves your problem.

When offing a voice, the release time is cut to a minimum. Dynamic
updates would reset this to the original value. The commit adds a way to
disable dynamic EG updates and does so when offing the voice.
The engine will also steal the oldest offed voice as a last resort to
hopefully sound the newly played note every time.
@paulfd paulfd merged commit 77fbfa5 into sfztools:develop Jun 26, 2022
@falkTX
Copy link
Contributor

falkTX commented Jun 30, 2022

@paulfd note stealing is much improved now, quickly using notes in succession triggers things properly, this is great to see thanks!

@falkTX
Copy link
Contributor

falkTX commented Jun 30, 2022

black midi still makes sfizz go bad, but that might be asking too much haha 😅
can recommend trying that out, https://github.com/x42/midigen.lv2 is a quick way to test that with its included tetris black midi song

@paulfd
Copy link
Member Author

paulfd commented Jun 30, 2022

I've received the Dwarf, and indeed performance is not amazing 😓 I'll try to improve it when I find the time (and unpile everything else)

@falkTX
Copy link
Contributor

falkTX commented Jun 30, 2022

Note that on dwarf there is an issue where RT operation stop while allocating memory on unrelated processes.
I was unable to find the reason why, but it is very easy to trigger by running a memory testing tool while dwarf is doing its business. Memory allocations can induce xruns.
This does not happen on duo or duox...

So the performance issues might be related, due to sfizz reallocating things on its background thread.
One possible thing to try is a fixed pool of memory. It will trigger xruns when plugin is first loaded, but then should be stable.

And yeah, I tried many things for priorities and cpu scheduling stuff. My current theory is on memory not being setup in the best way by the bootloader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing notes
2 participants