New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jack: Wait for CLI thread to finish on quit #1097

Merged

paulfd merged 1 commit into sfztools:develop from ColinKinloch:cli_thread_join

Jul 14, 2022

Contributor

ColinKinloch commented Jul 9, 2022

Before:

$ ./clients/sfizz_jack                                       
Flags
- Client name: sfizz
- Oversampling: 1x
- Preloaded size: 8192
- Num of voices: 32
- Audio Autoconnect: 0
- Verbose State: 0
Positional arguments:

> quit
Closing...
terminate called without an active exception
[1]    18124 IOT instruction (core dumped)  ./clients/sfizz_jack

After:

$ ./clients/sfizz_jack                                       
Flags
- Client name: sfizz
- Oversampling: 1x
- Preloaded size: 8192
- Num of voices: 32
- Audio Autoconnect: 0
- Verbose State: 0
Positional arguments:

> quit
Closing...


          jack: Wait for CLI thread to finish on quit

bbc7a0f

Member

paulfd commented Jul 14, 2022

Thanks for this !

paulfd merged commit 1eb728c into sfztools:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet