New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a bug that causes invalid effect output #1243

Merged

paulfd merged 1 commit into sfztools:develop from KKQ-KKQ:FixEffectOutputBug

Feb 13, 2024

Contributor

KKQ-KKQ commented Feb 13, 2024

The tempMixSpan didn't reset at a loop.
This cause an issue with the following sfz example.

<effect>
bus=fx1 type=fverb reverb_type=mid_hall reverb_dry=80 reverb_wet=20 reverb_input=40 reverb_size=0 reverb_predelay=0.01 reverb_tone=50 reverb_damp=50 fx1tomix=100
<global>
effect1=100
<region>sample=*sine
ampeg_attack=0.02 ampeg_release=0.1
output=0
<region>sample=*saw
ampeg_attack=0.02 ampeg_release=0.1
output=3

The 2nd and the 3rd output should be silent but actually it sounds.


          Fixed a bug that causes invalid effect output

4642b1e

KKQ-KKQ mentioned this pull request

Invalid output when the number of output is above 1 and using effects #1244

Closed

paulfd merged commit cc33ed1 into sfztools:develop

11 checks passed

Member

paulfd commented Feb 13, 2024

Nice catch thanks!

KKQ-KKQ deleted the FixEffectOutputBug branch

February 15, 2024 09:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet