Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add oscillator unison #161

Merged
merged 5 commits into from
Apr 7, 2020
Merged

Add oscillator unison #161

merged 5 commits into from
Apr 7, 2020

Conversation

jpcima
Copy link
Collaborator

@jpcima jpcima commented Apr 3, 2020

#146

This adds unison of oscillators.
The output is in stereo. Since stereo was only enabled for sample generators, I did a trick that enables it also in multi-oscillator mode.

Example

<region>
sample=*saw
oscillator=on
oscillator_detune=60
oscillator_multi=5

@jpcima jpcima requested a review from paulfd April 3, 2020 15:46
paulfd
paulfd approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@paulfd paulfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the small comment about the maxWaveOscillator configuration it looks good :)

src/sfizz/Voice.h Outdated Show resolved Hide resolved
@jpcima jpcima force-pushed the oscillator-multi branch from fb2dc60 to c4c4278 Compare April 7, 2020 14:24
@jpcima
Copy link
Collaborator Author

jpcima commented Apr 7, 2020

It's fixed.

@jpcima jpcima merged commit 332c752 into sfztools:develop Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulfd paulfd paulfd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpcima @paulfd