-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an opcode for note names, and API bindings for note and cc names #174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK to me!
Perhaps, we should export the library version number; (linked and built against) and |
I prefer to avoid specifying this part. The index must be in bounds. |
This might be an incomplete definition of the An example from Motif-XF-8
|
I've added following changes
|
Yes no problem, it is more coherent. @alcomposer I added the keyswitch label if you want to try with your branch! |
With the last addition, do we run the risk that the key could appear multiple times in the list? |
Yes, is it a problem? IIRC the DTD does not enforce unique values for this attribute. We run this risk for repeated |
Then it's no issue, let's validate in Ardour6 and this should be good |
cf https://www.midi.org/dtds/MIDINameDocument10.dtd.html Note that specifying unique attributes in XML is a bit involved I think, so it might be that they did not want to bother specifying it. However, we may be able to leave it to the host to choose what to do with duplicated notes (e.g. take the last, or take them all). In a way we're passing on the ambiguity from the sfz without committing to a resolution. |
@jpcima I'm not super sure about the C API design rules here
@redtide I added an
@version
tag, is this OK? We'll need to fix it before the release!@alcomposer you just need to integrate your note name midnam in Ardour now 🙂
Closes #154