Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support block comments #196

Merged
merged 4 commits into from
Apr 20, 2020
Merged

Support block comments #196

merged 4 commits into from
Apr 20, 2020

Conversation

jpcima
Copy link
Collaborator

@jpcima jpcima commented Apr 20, 2020

#195

This adds support of block comments in the parser.
There are some examples in the parser demo.

Maybe not all possibilities are supported.
For example, don't expect to be able to write: sample=/*blabla*/mycomment.wav

If the comment is not terminated with */, an error will be raised.

@jpcima jpcima requested a review from paulfd April 20, 2020 18:13
src/sfizz/parser/Parser.h Outdated Show resolved Hide resolved
@jpcima
Copy link
Collaborator Author

jpcima commented Apr 20, 2020

  • changed comment type to an enum
  • modified skipComment so the character count returned is correct
    (note it doesn't prevent the parser to work correctly, but better to fix it regardless)

@jpcima jpcima merged commit c2767b3 into sfztools:develop Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants