Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a sfizz_render client in-tree #200

Closed
wants to merge 3 commits into from
Closed

Conversation

paulfd
Copy link
Member

@paulfd paulfd commented Apr 22, 2020

This uses the fmidi library and its player, which adds a dependency on libev. The goal of having this client in-tree is to facilitate benchmarking of different versions.

@jpcima not sure I use your library right so check it 🙂

@paulfd paulfd requested a review from jpcima April 22, 2020 08:12
@jpcima
Copy link
Collaborator

jpcima commented Apr 22, 2020

This uses the fmidi library and its player, which adds a dependency on libev.

This is not true, it does not add a dependency on libev.
Only the example programs are dependent of the library, libev was moved out of the main library since a long time.

The library depends on boost and on fmt, and that's only for the description API which converts SMF to plain text.

I have around an edit of the library that can disable the above feature, such that it does not have external deps. Then it's a ~140K source code without recursive submodules.
https://github.com/jpcima/midiplay/tree/master/thirdparty/fmidi
https://github.com/jpcima/midiplay/blob/21c095fdf6b8326dc00608046e9ccf6f28b734a2/Makefile#L77

@paulfd
Copy link
Member Author

paulfd commented Apr 22, 2020

It seems I had to install libev to access the fmidi_player_XX interfaces? After some more reading it seems to be unneeded. There are these lines in the CMakeLists

find_library(ev_LIBRARY ev)
set(fmidi-player_BUILD FALSE)
if(ev_LIBRARY)
  set(fmidi-player_BUILD TRUE)
else()
  message(STATUS "libev is missing, NOT building library fmidi-player.")
endif()

clients/sfizz_render.cpp Outdated Show resolved Hide resolved
@jpcima
Copy link
Collaborator

jpcima commented Apr 22, 2020

It seems I had to install libev to access the fmidi_player_XX interfaces?

It's the example player that comes with as part of the library. (see programs/)

@paulfd
Copy link
Member Author

paulfd commented Apr 24, 2020

If we go with #201 can I close this one safely?

@jpcima
Copy link
Collaborator

jpcima commented Apr 25, 2020

Yes, it's no problem to close this one.
It's based on the identical commit ref 6f39d4c.

@paulfd paulfd closed this Apr 25, 2020
@paulfd paulfd deleted the render branch January 21, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants