Residual tiny quality of life changes in the LV2 plugin #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
paulfd
commented
May 13, 2020
paulfd
commented
- Oversampling parameter changes in LV2 takes the next power of 2 but does not upper bound the value
- Added the "fast path" check within sfizz (i.e. don't change if the current value is the same as the new one) for preload size, oversampling and polyphony. Easier and more encompassing to do it there rather than in the LV2, and it benefits everyone.
- Cosmetic changes for C-style struct initialization on atoms.
- Updated the docs.
jpcima
reviewed
May 13, 2020
lv2/sfizz.c
Outdated
| static void | ||
| sfizz_lv2_check_oversampling(sfizz_plugin_t* self) | ||
| { | ||
| sfizz_oversampling_factor_t oversampling = (sfizz_oversampling_factor_t)*self->oversampling_port; | ||
| if (oversampling != self->oversampling) | ||
| if (*self->oversampling_port < 0) |
There was a problem hiding this comment.
Maybe apply next-pow-2 first on the port value, then compare?
and this makes this condition superfluous, given the negative cases is already handled in next-pow-2?
There was a problem hiding this comment.
Yeah I was a bit wary since well, it looks like more operations but I guess it's not a big problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.