Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the opcode set_hdccN #233

Merged
merged 14 commits into from
May 16, 2020
Merged

Support the opcode set_hdccN #233

merged 14 commits into from
May 16, 2020

Conversation

jpcima
Copy link
Collaborator

@jpcima jpcima commented May 14, 2020

#232

Support set_hdccN and the equivalent set_realccN + test

@jpcima
Copy link
Collaborator Author

jpcima commented May 15, 2020

Ok so this PR went slightly overboard, I'll sum it up.
This is a set of additions to improve ARIA compatibility.

  • case sensitivity Opcode names are case-insensitive #234 handled in the cleanup
  • support set_lohdccN/set_hihdccN and aliases
  • support lohdccN/hihdccN
  • support start_lohdccN/start_hihdccN and aliases
  • applied cleanups to all opcodes everywhere (was <region> only)
  • all relevant tests

@jpcima jpcima requested a review from paulfd May 15, 2020 06:36
@jpcima
Copy link
Collaborator Author

jpcima commented May 16, 2020

These new opcodes are tested against ARIA, working as expected.
I merge it. This adds support of Naked Drums which needs set_hdcc to initialize its volumes.

@jpcima jpcima merged commit 9c93120 into sfztools:develop May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulfd paulfd Awaiting requested review from paulfd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jpcima