Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the API to receive hdcc values #244

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Conversation

jpcima
Copy link
Collaborator

@jpcima jpcima commented May 17, 2020

This is so synth UIs can manipulate sfizz controllers with full precision.
New API: sfizz_send_hdcc

@rghvdberg

@paulfd
Copy link
Member

paulfd commented May 21, 2020

We could argue whether a new name is necessary rather than an overload. I think that it's better to have a different name, since it could be maybe confusing for the value 1. I believe overload resolution would prefer the integer version in this case?

I have to admit I had in mind to deprecate the uint8_t version of the API at some point after the change to float in the internal engine, and let front-ends do their normalization if necessary. VST3 sends normalized CC already IIRC. Keeping both APIs does not make it very clear that we're basically converting the uint8_t to float internally.

@jpcima
Copy link
Collaborator Author

jpcima commented May 22, 2020

We could argue whether a new name is necessary rather than an overload

Overloading is preferably avoided, in general. It introduces selection and masking problems.
This makes the compiler's job harder, and the programmer's job as well, just as you have noted.

@jpcima jpcima merged commit db27cb0 into sfztools:develop Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants