Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the VST plugin #282

Merged
merged 5 commits into from
Jun 21, 2020
Merged

Update the VST plugin #282

merged 5 commits into from
Jun 21, 2020

Conversation

jpcima
Copy link
Collaborator

@jpcima jpcima commented Jun 20, 2020

  • add tuning
  • add tuning UI
  • add value labels
  • restore file paths on UI reopened
  • update the state format

@jpcima jpcima requested a review from paulfd June 20, 2020 10:37
@paulfd
Copy link
Member

paulfd commented Jun 21, 2020 •
edited
Loading

I rebased and changed the number of voices. I gave it a push in Reaper and it seems to work nicely! Let CI run and we can merge it from my side 🙂

@jpcima
Copy link
Collaborator Author

jpcima commented Jun 21, 2020

You're right on this, it needs to edit SfizzVstState.h and change 256 to 64.

@paulfd
Copy link
Member

paulfd commented Jun 21, 2020

I did it wrong in (80d4eaf)?

@paulfd
Copy link
Member

paulfd commented Jun 21, 2020

I have to admit I'm relying alot on you for the VST internals :D

@jpcima
Copy link
Collaborator Author

jpcima commented Jun 21, 2020

It looks fine; I hadn't noticed about this one.
I read that LV2 has the lower bound to 8, do you want to make it the same here ?

@jpcima jpcima merged commit 2338bd8 into sfztools:develop Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulfd paulfd paulfd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpcima @paulfd