Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "sustain_cc=" and "trigger=release_key" #298

Merged
merged 4 commits into from
Jul 8, 2020

Conversation

paulfd
Copy link
Member

@paulfd paulfd commented Jul 1, 2020

This should implement the proper behavior regarding the sustain pedal and the trigger=release/release_key opcode value.

Closes #68

@paulfd paulfd marked this pull request as draft July 1, 2020 14:00
@paulfd paulfd mentioned this pull request Jul 1, 2020
@paulfd paulfd requested a review from jpcima July 1, 2020 14:32
@paulfd paulfd marked this pull request as ready for review July 1, 2020 14:32
@paulfd
Copy link
Member Author

paulfd commented Jul 1, 2020

This will require further architectural work, so I'm delegating the finer behavior to the next release for now.

@jpcima
Copy link
Collaborator

jpcima commented Jul 7, 2020

I must admit to be a bit confused at the noteIsOff state.
this flag is suppsed to indicate a note which is on sustain ?
it's normal that noteIsOff is present in both Voice and Region?

@paulfd
Copy link
Member Author

paulfd commented Jul 7, 2020

Yes both flags are set at the same time normally but with different effects let's say. The one in the region is for notes that did not start yet but will start on pedal down. The one in the voice is the opposite. I guess they could use the same flag, with the Voice calling the Region one.

Overall I'm not an entire fan of the "region state" handling but I'm failing to come up with an overall better plan. In many cases it's kind of hard to separate what should be stored into the region object, the midi state, or the voice itself.

@paulfd paulfd merged commit bcff0aa into sfztools:develop Jul 8, 2020
@paulfd paulfd deleted the release-key branch July 8, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Differentiate release and release_key
2 participants