Readable active voices #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The same attempt for VST. However it works weird in several host software in various ways, so maybe not worth to add it. |
|
Alternative implementation with control port. It works in Carla, Ardour. |
jpcima
approved these changes
Jul 26, 2020
…h call to the getter
…tive voices All tests updated as this was the previous default behavior.
jpcima
force-pushed
the
readable-active-voices
branch
from
ddcbec7 to
ab6086b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems Ardour does not understand the patch:Set for this particular property, I'll investigate.
Closes: sfztools/sfizz-ui#80