Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lv2/sfizz.c: options terminator must have both key and value as 0 #323

Merged
merged 1 commit into from
Jul 18, 2020

Conversation

atsushieno
Copy link
Contributor

This fixes the problem with such a condition that a host passes a list of
options where any option with value 0 precedes the block sizes.

From http://lv2plug.in/ns/ext/options#options:

To implement this feature, hosts MUST pass an LV2_Feature to the appropriate instantiate method with this URI and data pointed to an array of LV2_Options_Option terminated by an element with both key and value set to zero.

This fixes the problem with such a condition that a host passes a list of 
options where any option with value `0` precedes the block sizes.

From http://lv2plug.in/ns/ext/options#options:

> To implement this feature, hosts MUST pass an LV2_Feature to the appropriate instantiate method with this URI and data pointed to an array of LV2_Options_Option terminated by an element with both key and value set to zero.
@paulfd
Copy link
Member

paulfd commented Jul 18, 2020

Nice, thanks!

@paulfd paulfd merged commit 0160af3 into sfztools:develop Jul 18, 2020
@atsushieno atsushieno deleted the patch-1 branch July 18, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants