-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release logic (multiple notes for release=trigger + rt_dead handling) #324
Conversation
At this point maybe it would be more "logical" to let the Region object be purely a data storage, and handle all the changes of the "status" of each regions within the Synth (i.e. instead of having the |
Without a doubt yes. This helps to manage the complexity a bit as the software grows. |
Sure and sure. I'll defer the passive region in another pull request, and feel free to reorganize the sources 🙂 |
c8085db
to
0ea2789
Compare
0ea2789
to
cb367d3
Compare
I added tests and support for the The architecture is not entirely satisfactory but I will defer overhauling the activations/dispatching in another PR. The tests added in this one will help ensure nothing breaks, and I will add a more comprehensive set in the upcoming PR as this is relatively easy to test programmatically. |
Closes: #299