Polyphony cleanups #393
Merged
Polyphony cleanups #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the polyphony checks into reusable blocks
…nd release regions
Basically if group=off_by, a note will not choke other voices with the same note number
paulfd
force-pushed
the
polyphony-cleanups
branch
from
ed9d17f to
863a08c
Compare
jpcima
reviewed
Sep 9, 2020
|
I seems can't get the trigger=release to works in the newest build. Something's missing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly splitting up the various polyphony checks and overall voice starting logic in the synth into smaller methods, and using them on all events instead of only note ons.
This should close #372.
I'll add some inbuilt tests from the sfz test suite before merging I think, to check that we do cover relevant behavior on all fronts.